Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX - info message must be lowercase #2131

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

floverdevel
Copy link
Contributor

Q A
Type improvement
BC Break no
Fixed issues

Summary

Some messages are rendered as Hydrator classes generated to "path/to/my/project/var/pre-cached/Hydrators</INFO>".
Because the opening and closing tags are not case sensitive.
So i use </info> instead of </INFO> for these messages.

Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase your branch on top of 1.3.x since this is a bugfix. To do so:

  1. Fetch all new commits: git fetch --all. ⬇️
  2. git rebase --onto 1.3.x master fix-info-lowercase
  3. Force push to overwrite all this : git push --force. ⬆️

@floverdevel
Copy link
Contributor Author

Allright, I will do that tonight 😁

@Steveb-p
Copy link
Contributor

Steveb-p commented Dec 3, 2019

3. Force push to overwrite all this : git push --force.

@alcaeus --force-with-lease is usually the safer version that ensures no commits from remote are lost if someone pushes mid fetch-push operation.

@alcaeus
Copy link
Member

alcaeus commented Dec 3, 2019

@Steveb-p: while I normally agree, that entire point is moot if you’ve just fetched and you’re pushing to a repository/branch where you’re the only one pushing to 😉

@floverdevel
Copy link
Contributor Author

I rebased on 1.3.x but i supposed I should also change the destination of my PR to 1.3.x instead of master.

@floverdevel floverdevel changed the base branch from master to 1.3.x December 4, 2019 03:09
@alcaeus alcaeus self-assigned this Dec 4, 2019
@alcaeus alcaeus added the Bug label Dec 4, 2019
@alcaeus alcaeus added this to the 1.3.6 milestone Dec 4, 2019
@alcaeus alcaeus added this to 1.3 (bug fixes only) in Roadmap Dec 4, 2019
@alcaeus alcaeus merged commit ae19ce4 into doctrine:1.3.x Dec 4, 2019
@alcaeus
Copy link
Member

alcaeus commented Dec 4, 2019

I rebased on 1.3.x but i supposed I should also change the destination of my PR to 1.3.x instead of master.

Yep - that's the part that most people don't have trouble with, which is why I omitted it. You are right of course.

Thanks for fixing this, @floverdevel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Roadmap
1.3 (unsupported)
Development

Successfully merging this pull request may close these issues.

None yet

3 participants