-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX - info message must be lowercase #2131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase your branch on top of 1.3.x since this is a bugfix. To do so:
- Fetch all new commits:
git fetch --all
. ⬇️ git rebase --onto 1.3.x master fix-info-lowercase
- Force push to overwrite all this :
git push --force
. ⬆️
Allright, I will do that tonight 😁 |
@alcaeus |
@Steveb-p: while I normally agree, that entire point is moot if you’ve just fetched and you’re pushing to a repository/branch where you’re the only one pushing to 😉 |
42f9e09
to
45543f1
Compare
I rebased on |
Yep - that's the part that most people don't have trouble with, which is why I omitted it. You are right of course. Thanks for fixing this, @floverdevel! |
Summary
Some messages are rendered as
Hydrator classes generated to "path/to/my/project/var/pre-cached/Hydrators</INFO>"
.Because the opening and closing tags are not case sensitive.
So i use
</info>
instead of</INFO>
for these messages.