Alias for Lookup with Relationship

[josemiguelq]

Q	A
Type	improvement
BC Break	no
Fixed issues

Summary

According to the documentation of Mongo the as can't be null because contains the matching documents from the from collection.
(https://docs.mongodb.com/manual/reference/operator/aggregation/lookup/#lookup-join-as).

To prevent error the keys will be the same of the Documents using "mappedBy" and the foreignKey will be the same of attribute "name".

[alcaeus]

Thanks for your contribution! This needs a little more work:

1. Please give your commit a good title. "Use field name as default alias in Lookup stage" would be a good title.
2. Rebase your commit on the 1.3.x branch and re-target the pull request to that branch, as this is a bug we should fix in the oldest supported version
3. Please add a test for it, there are a couple of tests for the Lookup stage already.

Please let me know if you need help with any of the above!

[josemiguelq]

Thanks for your contribution! This needs a little more work:

1. Please give your commit a good title. "Use field name as default alias in Lookup stage" would be a good title.
2. Rebase your commit on the 1.3.x branch and re-target the pull request to that branch, as this is a bug we should fix in the oldest supported version
3. Please add a test for it, there are a couple of tests for the Lookup stage already.

Please let me know if you need help with any of the above!

Thanks @alcaeus , I'll do the corrections that you pointed.

[josemiguelq]

@alcaeus , checks my updates please?

[alcaeus]

There are lots of unrelated changes in this PR regarding indentation. Please refrain from changing the coding style on unrelated changes. If your IDE is doing this automatically, please tell it to stop doing that 😉

As for the tests, those look good so far. The two classes you introduced aren't necessary. For the mapping changes, was the storeAs attribute required to make tests pass? Inverse references shouldn't care about their own storeAs, as they're defined by the storeAs value of the owning side. If the test fails without this mapping, this points to a different problem with the lookup implementation (which I'd have to debug separately).

[josemiguelq]

@alcaeus , request changes done. Thanks for the review and advice.

[alcaeus]

@josemiguelq there are some more indentation changes that you haven't changed back. Please go through those and make sure to not have any unrelated changes in. The rest looks good 👍

[josemiguelq]

@josemiguelq there are some more indentation changes that you haven't changed back. Please go through those and make sure to not have any unrelated changes in. The rest looks good 👍

Sorry @alcaeus, indentation changes done. Its IDE default behavior

[alcaeus]

Thanks @josemiguelq!

Note: travis-ci completed successfully but did not correctly report the status to GitHub.