Typed properties support #2188
Merged
Typed properties support #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haven’t checked the source entirely yet, but given that we’re changing a bunch of internals I’d suggest fixing this in 2.0 instead of 2.1. I’m not sure we should consider this a bug fix for 2.0. |
malarzm
commented
May 23, 2020
tests/Doctrine/ODM/MongoDB/Tests/Mapping/AnnotationDriverTest.php
Outdated
Show resolved
Hide resolved
|
@alcaeus the true part of the fix is couple of lines long, this won't be too much hassle to include in 2.0.x IMO |
malarzm
force-pushed
the
typed-props
branch
4 times, most recently
from
4ce0ba2
to
81caeab
Compare
alcaeus
approved these changes
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2161