Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PrettyVersion 2 #2275

Merged
merged 1 commit into from Feb 1, 2021
Merged

Allow PrettyVersion 2 #2275

merged 1 commit into from Feb 1, 2021

Conversation

Jean85
Copy link
Contributor

@Jean85 Jean85 commented Jan 29, 2021

Q A
Type improvement
BC Break no
Fixed issues None

Summary

This simple bump allows for the 2.0 version of this lib, which leverages Composer 2 APIs and drops any sub dependency.

There are basically no BC; for more details, see the the changelog.

This could be easily cherry-picked in the 2.0 and 2.1 branches if needed.

@malarzm malarzm added this to the 2.2.1 milestone Feb 1, 2021
@malarzm malarzm added this to 2.2 (bug fixes only) in Roadmap Feb 1, 2021
@malarzm malarzm added the Task label Feb 1, 2021
@malarzm
Copy link
Member

malarzm commented Feb 1, 2021

Thanks a lot @Jean85!

@malarzm malarzm merged commit 4269eea into doctrine:master Feb 1, 2021
@Jean85 Jean85 deleted the patch-1 branch February 1, 2021 21:11
@IonBazan
Copy link
Member

@malarzm I think this change was not merged into 2.2.x branch: https://github.com/doctrine/mongodb-odm/blob/2.2.1/composer.json but was mentioned in release notes: https://github.com/doctrine/mongodb-odm/releases/tag/2.2.1 Can you cherry-pick it and merge into 2.2.x and maybe some older branches too?

@alcaeus
Copy link
Member

alcaeus commented May 21, 2021

You are correct, this PR incorrectly used the 2.2.1 milestone despite going into the 2.3.x branch today (then still called master). I'm hesitant to backport this now, especially with the release of 2.3 imminent (just waiting to wrap up #2238 and #2308 here as well as a bundle change).

@alcaeus alcaeus modified the milestones: 2.2.1, 2.3.0 May 21, 2021
@alcaeus alcaeus moved this from 2.2 (bug fixes only) to 2.3 (in development) in Roadmap May 21, 2021
@alcaeus alcaeus modified the milestones: 2.3.0-alpha1, 2.3.0 Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Roadmap
2.3 (unsupported)
Development

Successfully merging this pull request may close these issues.

None yet

4 participants