fluent interface for DocumentManager #234
Conversation
| $this->assertInstanceOf('Doctrine\ODM\MongoDB\DocumentManager', $this->dm->detach($document)); | ||
|
|
||
| $this->assertInstanceOf('Doctrine\ODM\MongoDB\DocumentManager', $this->dm->remove($document)); | ||
| $this->assertInstanceOf('Doctrine\ODM\MongoDB\DocumentManager', $this->dm->clear()); |
There was a problem hiding this comment.
I think you should even use assertSame here to check that the value returned is the same DocumentManager instance, not another one
|
👎 I don't think a fluent interface makes sense on the DocumentManager. |
<?php
$dm
->persist($document)
->flush()
;feels more natural than |
|
The DocumentManager methods are not the type of class you apply a fluent interface to. It violates the principle that methods should just do one thing when using a fluent interface. The methods you are chaining are not setters, they are operations so they should return null. |
|
another note from @beberlei: "fowler states it this way: the essence of Fluent Interfaces is that they approach thinking about using components differently … we think linguistically of composing sentences using clauses that weave objects together. a fluent interface is about a DSL or a linguistic sentence, in case of the entity manager this does not make sense semantically" |
No description provided.