Fix sql walker phpdoc

doctrine · Feb 23, 2024 · 0f8d193 · 0f8d193
1 parent e6eef1a
commit 0f8d193
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 34 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -330,21 +330,6 @@ parameters:
 			count: 1
 			path: src/Query/AST/Functions/DateSubFunction.php
 
-		-
-			message: "#^Parameter \\#1 \\$simpleArithmeticExpr of method Doctrine\\\\ORM\\\\Query\\\\SqlWalker\\:\\:walkSimpleArithmeticExpression\\(\\) expects Doctrine\\\\ORM\\\\Query\\\\AST\\\\SimpleArithmeticExpression, Doctrine\\\\ORM\\\\Query\\\\AST\\\\Node given\\.$#"
-			count: 1
-			path: src/Query/AST/Functions/LengthFunction.php
-
-		-
-			message: "#^Parameter \\#1 \\$simpleArithmeticExpr of method Doctrine\\\\ORM\\\\Query\\\\SqlWalker\\:\\:walkSimpleArithmeticExpression\\(\\) expects Doctrine\\\\ORM\\\\Query\\\\AST\\\\SimpleArithmeticExpression, Doctrine\\\\ORM\\\\Query\\\\AST\\\\Node given\\.$#"
-			count: 1
-			path: src/Query/AST/Functions/LowerFunction.php
-
-		-
-			message: "#^Parameter \\#1 \\$simpleArithmeticExpr of method Doctrine\\\\ORM\\\\Query\\\\SqlWalker\\:\\:walkSimpleArithmeticExpression\\(\\) expects Doctrine\\\\ORM\\\\Query\\\\AST\\\\SimpleArithmeticExpression, Doctrine\\\\ORM\\\\Query\\\\AST\\\\Node given\\.$#"
-			count: 1
-			path: src/Query/AST/Functions/UpperFunction.php
-
 		-
 			message: "#^Method Doctrine\\\\ORM\\\\Query\\\\AST\\\\IndexBy\\:\\:dispatch\\(\\) should return string but returns void\\.$#"
 			count: 1

diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -1577,11 +1577,6 @@
       <code><![CDATA[$assoc['joinColumns']]]></code>
     </PossiblyUndefinedArrayOffset>
   </file>
-  <file src="src/Query/AST/Functions/LengthFunction.php">
-    <ArgumentTypeCoercion>
-      <code><![CDATA[$this->stringPrimary]]></code>
-    </ArgumentTypeCoercion>
-  </file>
   <file src="src/Query/AST/Functions/LocateFunction.php">
     <PossiblyInvalidArgument>
       <code><![CDATA[$this->simpleArithmeticExpression]]></code>
@@ -1590,11 +1585,6 @@
       <code><![CDATA[$parser->SimpleArithmeticExpression()]]></code>
     </PossiblyInvalidPropertyAssignmentValue>
   </file>
-  <file src="src/Query/AST/Functions/LowerFunction.php">
-    <ArgumentTypeCoercion>
-      <code><![CDATA[$this->stringPrimary]]></code>
-    </ArgumentTypeCoercion>
-  </file>
   <file src="src/Query/AST/Functions/ModFunction.php">
     <PossiblyInvalidPropertyAssignmentValue>
       <code><![CDATA[$parser->SimpleArithmeticExpression()]]></code>
@@ -1622,11 +1612,6 @@
       <code><![CDATA[$parser->SimpleArithmeticExpression()]]></code>
     </PossiblyInvalidPropertyAssignmentValue>
   </file>
-  <file src="src/Query/AST/Functions/UpperFunction.php">
-    <ArgumentTypeCoercion>
-      <code><![CDATA[$this->stringPrimary]]></code>
-    </ArgumentTypeCoercion>
-  </file>
   <file src="src/Query/AST/GeneralCaseExpression.php">
     <ParamNameMismatch>
       <code>$sqlWalker</code>
@@ -2131,9 +2116,6 @@
     <NoValue>
       <code>$expression</code>
     </NoValue>
-    <PossiblyInvalidArgument>
-      <code><![CDATA[$aggExpression->pathExpression]]></code>
-    </PossiblyInvalidArgument>
     <PossiblyNullArgument>
       <code><![CDATA[$AST->whereClause]]></code>
       <code><![CDATA[$AST->whereClause]]></code>

diff --git a/src/Query/SqlWalker.php b/src/Query/SqlWalker.php
@@ -2588,7 +2588,7 @@ public function walkArithmeticExpression($arithmeticExpr)
     /**
      * Walks down an SimpleArithmeticExpression AST node, thereby generating the appropriate SQL.
      *
-     * @param AST\SimpleArithmeticExpression $simpleArithmeticExpr
+     * @param AST\Node|string $simpleArithmeticExpr
      *
      * @return string
      *