Error: Expected Doctrine\ORM\Query\Lexer::T_FROM, got EntityName since upgrade to 2.6.0

[allan-simon]

I have the following builder request

          return $builder
              ->select('e')
              ->from('AppBundle:Event', 'e')
              ->addSelect('MIN(o.startTime) AS HIDDEN')
              ->leftJoin('e.occurences', 'o')
              ->where('o.startTime BETWEEN CURRENT_DATE() AND :date ')
              ->andWhere('e.published = true')
              ->andWhere('e.place = :place')
              ->groupBy('e.id')
              ->setMaxResults(10)
              ->setParameter(':date', $date)
              ->setParameter(':place', $place)
              ->getQuery()
              ->getResult()
          ;   

it used to work fine, but since upgrade to 2.6.0 I got the error

[Syntax Error] line 0, col 42: Error: Expected Doctrine\ORM\Query\Lexer::T_FROM, got 'AppBundle:Event'

It seems to work if I add FROM like this :

              ->from(' FROM AppBundle:Event', 'e')

is it a known issue ? (or something wrong in my original code ?)

[Ocramius]

What's the generated DQL string for that query builder?

[allan-simon]

how do i get it ?

[Ocramius]

Instead of ->getQuery() do a ->getDQL()

[Majkl578]

On master, QB generates following DQL:

SELECT e, MIN(o.startTime) AS HIDDEN FROM AppBundle:Event e LEFT JOIN e.occurences o WHERE (o.startTime BETWEEN CURRENT_DATE() AND :date ) AND e.published = true AND e.place = :place GROUP BY e.id

So there is obviously missing alias for MIN() function.

[Ocramius]

"HIDDEN" is a reserved DQL keyword

…

On 21 Dec 2017 17:35, "Michael Moravec" ***@***.***> wrote: On master, QB generates following DQL: SELECT e, MIN(o.startTime) AS HIDDEN FROM AppBundle:Event e LEFT JOIN e.occurences o WHERE (o.startTime BETWEEN CURRENT_DATE() AND :date ) AND e.published = true AND e.place = :place GROUP BY e.id So there is obviously missing alias for MIN() function. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#6932 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJakMI1jPG4A6MrbXMtaOrZSgPm1YZwks5tCojhgaJpZM4RJ-e3> .

[Majkl578]

"HIDDEN" is a reserved DQL keyword

Yes, but the query is valid according to 2.5 EBNF:

SelectExpression        ::= (IdentificationVariable | ScalarExpression | AggregateExpression | FunctionDeclaration | PartialObjectExpression | "(" Subselect ")" | CaseExpression | NewObjectExpression) [["AS"] ["HIDDEN"] AliasResultVariable]

"AS HIDDEN" is fine and the alias should be optional as well (which sounds a bit strange though).

This is not a QueryBuilder bug which generates same DQL as on 2.5, but a parser bug.

LanguageRecognitionTest test case:

    public function testOmittingAliasVariableInSelectExpression() : void
    {
        $this->assertValidDQL('SELECT g, LENGTH(g.from) AS HIDDEN FROM ' . DQLKeywordsModelGroup::class . ' g');
    }

Works with 2.5, fails with 2.6.
Bisected to b7bd426 so it's related to #6928.

[stof]

Not, the EBNF has [["AS"] ["HIDDEN"] AliasResultVariable]. so AS HIDDEN is not valid, as you miss the AliasResultVariable

[beberlei]

Fixed by #7077