Bump Psalm to 5.0.0 and fix errors for Symfony 6.2 #10261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The breaking test seems to have to do with |
|
It looks as if Line 69 in 65da1fe 100 was used instead.
|
|
This is the commit that breaks the test according to git bisect: symfony/console@5edfa27 Full PR at symfony/symfony#45318 |
That setting still is ignored: If I set it to |
|
Must be a red herring, let's try the solution mentioned here: https://github.com/symfony/symfony-docs/pull/16476/files |
That PR was closed in favor of symfony/symfony#47062 |
|
I don't think we can access the output wrapper form the test, so maybe let's just drop this |
|
Yes, that's what I did now. |
greg0ire
approved these changes
Nov 30, 2022
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Nov 30, 2022
* 2.13.x: Bump Psalm to 5.0.0 and fix errors for Symfony 6.2 (doctrine#10261) Leverage Lexer's Token type (follow up)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Nov 30, 2022
* 2.14.x: Bump Psalm to 5.0.0 and fix errors for Symfony 6.2 (doctrine#10261) Make use statements redundant Leverage Lexer's Token type (follow up)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Symfony 6.2 release breaks our static analysis once again. This PR should fix the issue.