Migrate files with the least changes to PHP 8 #10367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
commented
Jan 3, 2023
| @@ -102,9 +102,9 @@ public function count(): int | |||
| /** | |||
| * {@inheritdoc} | |||
| * | |||
| * @psalm-return Traversable<array-key, T> | |||
| * @psalm-return Traversable<array-key, T>&ArrayIterator | |||
There was a problem hiding this comment.
Here, we can't just use ArrayIterator<array-key, T> because that would make T appear in an invariant position, while it's declared as covariant.
There was a problem hiding this comment.
Do we want ArrayIterator to be part of the contract? I don't see a reason to change the return type.
There was a problem hiding this comment.
🤔 hum you're right, it makes no sense to leak that info.
These are the lowest hanging fruits I could find after running Rector: I looked for files with a diff of 2 lines. I did not include some changes that I find controversial, such as marking some constants as final when we should maybe consider making classes themselves final.
greg0ire
force-pushed
the
php8-migration
branch
from
181c5e5
to
7e379f6
Compare
SenseException
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the lowest hanging fruits I could find after running Rector: I looked for files with a diff of 2 lines.
I did not include some changes that I find controversial, such as marking some constants as final when we should maybe consider making classes themselves final.