Migrate exceptions to PHP 8 syntax #10380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
php8-migration-exceptions
branch
from
29185ad
to
cb8da13
Compare
derrabus
requested changes
Jan 9, 2023
| @@ -865,8 +547,7 @@ public static function illegalOverrideOfInheritedProperty($className, $propertyN | |||
| ); | |||
| } | |||
|
|
|||
| /** @return self */ | |||
| public static function invalidIndexConfiguration($className, $indexName) | |||
| public static function invalidIndexConfiguration($className, $indexName): self | |||
| @@ -877,8 +558,7 @@ public static function invalidIndexConfiguration($className, $indexName) | |||
| ); | |||
| } | |||
|
|
|||
| /** @return self */ | |||
| public static function invalidUniqueConstraintConfiguration($className, $indexName) | |||
| public static function invalidUniqueConstraintConfiguration($className, $indexName): self | |||
greg0ire
force-pushed
the
php8-migration-exceptions
branch
2 times, most recently
from
5623b6a
to
f9a1e37
Compare
SenseException
previously requested changes
Jan 9, 2023
Co-authored-by: Alexander M. Turek <me@derrabus.de> Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com>
greg0ire
force-pushed
the
php8-migration-exceptions
branch
from
fe64ec2
to
c313440
Compare
derrabus
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.