Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove concrete table inheritance #10414

Merged
merged 1 commit into from Jan 18, 2023
Merged

Remove concrete table inheritance #10414

merged 1 commit into from Jan 18, 2023

Conversation

mpdude
Copy link
Contributor

@mpdude mpdude commented Jan 17, 2023 •
edited

This seems to be a leftover from early days, but never actually implemented or documented.

#10423 adds the deprecation notices in 2.14.

Closes #7371, references #10217, closes #10220.

@mpdude mpdude changed the base branch from 2.14.x to 3.0.x January 17, 2023 11:08
@mpdude mpdude changed the title remove concrete table inheritance Remove concrete table inheritance Jan 17, 2023
greg0ire
greg0ire approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not implemented in a decade. Let's indeed clean this up 👍

@mpdude
Copy link
Contributor Author

mpdude commented Jan 17, 2023

Since it technically a BC break, do we require deprecation warnings or similar in 2.x?

@greg0ire
Copy link
Member

greg0ire commented Jan 17, 2023 •
edited

It can't hurt to do so. If you do, you'll have to add something in UPGRADE.md about this, and also, you will have to edit UPGRADE.md in this PR with s/deprecated/removed/

@mpdude
Copy link
Contributor Author

mpdude commented Jan 17, 2023

I don't know how access to a const could be deprecated, and where can I find the pattern that this project uses to announce deprecations (e. g. a @trigger_error(...) or so?)

@greg0ire
Copy link
Member

For once, we have a clearly documented policy on this: https://www.doctrine-project.org/policies/deprecation.html 🙂

TL;DR: use Deprecation::trigger(), and when you can't, use @deprecated

@mpdude mpdude mentioned this pull request Jan 18, 2023
Merged
@derrabus derrabus added this to the 3.0.0 milestone Jan 18, 2023
@derrabus derrabus merged commit 7a08253 into doctrine:3.0.x Jan 18, 2023
@mpdude mpdude deleted the remove-concrete-table-inheritance branch January 18, 2023 16:22
@mpdude mpdude mentioned this pull request Jan 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@SenseException SenseException SenseException approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
BC Break
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mpdude @greg0ire @SenseException @derrabus