Field mapping DTO #10607
Merged
Field mapping DTO #10607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are going to have many DTOs, all of which will need an array access implementation as a backward compatibility layer.
12 tasks
greg0ire
force-pushed
the
field-mapping-dto
branch
from
fcda732
to
c0fe182
Compare
derrabus
previously requested changes
Mar 31, 2023
In the past, it has been decided to use arrays for this out of legitimate performance concerns. But PHP has evolved, and now, it is more performant and memory efficient to use objects.
greg0ire
force-pushed
the
field-mapping-dto
branch
from
4f9ba82
to
175cdef
Compare
SenseException
approved these changes
Mar 31, 2023
| @@ -257,7 +257,7 @@ private function formatMappings(array $propertyMappings): array | |||
| foreach ($propertyMappings as $propertyName => $mapping) { | |||
| $output[] = $this->formatField(sprintf(' %s', $propertyName), ''); | |||
|
|
|||
| foreach ($mapping as $field => $value) { | |||
| foreach ((array) $mapping as $field => $value) { | |||
There was a problem hiding this comment.
I assume having an IteratorAggregate would be too much and is supposed to be kept simple.
There was a problem hiding this comment.
Yes, and it's not like this is a collection or something.
|
Thank you for the effort of splitting up the former PR. ❤️ |
greg0ire
dismissed
derrabus’s stale review
The requested changes have been addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, it has been decided to use arrays for this out of
legitimate performance concerns. But PHP has evolved, and now, it is
more performant and memory efficient to use objects.