Move joinTableColumns down #10636
Merged
Move joinTableColumns down #10636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At this point you're probably wondering why I'm not pushing the switch to the object API of the association mapping… well, it comes with lots of errors. In this cases, it's revealing a flaw in my design, so that's good I guess, and we shouldn't add the errors to the baseline too quickly. I'm going to do small PRs that should prevent some of them from ever showing up. |
This field only makes sense for the owning side of many-to-many mappings. Moving it down allows us to make it non-nullable.
greg0ire
force-pushed
the
join-table-columns-down
branch
from
a23d288
to
49cc83d
Compare
greg0ire
commented
Apr 17, 2023
| - | ||
| message: "#^Access to an undefined property Doctrine\\\\ORM\\\\Mapping\\\\AssociationMapping\\:\\:\\$joinTableColumns\\.$#" | ||
| path: lib/Doctrine/ORM/Persisters/Collection/ManyToManyPersister.php | ||
|
|
There was a problem hiding this comment.
This is caused by the issue already linked line 27
SenseException
approved these changes
Apr 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field only makes sense for the owning side of many-to-many mappings. Moving it down allows us to make it non-nullable.