Allow DateTimeImmutable be part of composite key
#10830
Conversation
Greg0
changed the title
Greg0
changed the title
DateTimeImmutable be part of composite key
What do you mean? |
Greg0
force-pushed
the
datetime-composite-key
branch
from
3512b6e
to
7c049fe
Compare
|
You may disregard the documentation build, it's not stable yet. |
|
When can I expect a review of PR? |
| { | ||
| $article = new Article('Some title'); | ||
| $article->changeTitle('New title'); | ||
| sleep(1); |
There was a problem hiding this comment.
Please find a way to avoid this. Maybe define a class that extends DateTimeImmutable and makes sure to add 1 second when the constructor is called, I don't know.
BTW, doesn't this point at a weakness of having time part of the composite key? What happens in high throughput scenarios? People might end up with entities with the same ID, might they not? I'm starting to have some doubts about this…
There was a problem hiding this comment.
I consider such validation as a part of entity design. Ofc I can add that validation in tested entities to get rid of that sleep function.
It is not the responsibility of Doctrine to think for programmers on the consistency of their entities.
There was a problem hiding this comment.
It's not that I want to tell people what's wrong or right, but I would like to avoid people opening bug reports, have us help them debug only to find they are hitting this limitation. That's why I'm weary of code that works only if people know what they are doing.
There was a problem hiding this comment.
Agree but requirement of having unique entity identifier is not magic knowledge when you are dealing with ORM and even database I guess. What do you think?
There was a problem hiding this comment.
It sounds sensible. Let's keep that thread open, and see what other maintainers think.
I've only noticed issues with documentation checks |
It appears in the form of comments on the files tab, when you have a successful build (which explains why it isn't available right now). |
Greg0
force-pushed
the
datetime-composite-key
branch
from
a9d437a
to
a4bfaa3
Compare
Everything passed now |
|
This is what I'm talking about:
|
Greg0
force-pushed
the
datetime-composite-key
branch
from
b02f1b2
to
d381656
Compare
|
@greg0ire Can you point me to a place where tests that cover |
|
I'm on my phone so no. Have you tried throwing an exception in nearby code and running the test suite. |
I figured out how to check that part of the code. I need more time for that and I'll let you know when it will be finished |
|
Any news? Faced same problem with |
I've added implementation for the attached previously use-case.
The whole description can be found in the linked issue #10831