Use lazy ghosts unconditionally #10969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
lazy-ghosts-unconditionally
branch
from
347f008
to
4e3e8bd
Compare
greg0ire
commented
Oct 7, 2023
| * @param class-string $className | ||
| * @param array<mixed> $identifier | ||
| * | ||
| * @return InternalProxy |
There was a problem hiding this comment.
Using a native return type here will involve modify some tests that mock calls to getProxy and make them return actual entities.
There was a problem hiding this comment.
I think we should fix those tests, but that could be done in a follow-up.
derrabus
reviewed
Oct 7, 2023
| * @param class-string $className | ||
| * @param array<mixed> $identifier | ||
| * | ||
| * @return InternalProxy |
There was a problem hiding this comment.
I think we should fix those tests, but that could be done in a follow-up.
greg0ire
force-pushed
the
lazy-ghosts-unconditionally
branch
from
c39297a
to
e5122b0
Compare
Yeah me too… but I haven't found a clear solution so far. |
derrabus
reviewed
Oct 7, 2023
Extending it no longer serves any purpose.
derrabus
force-pushed
the
lazy-ghosts-unconditionally
branch
from
e5122b0
to
a511ab3
Compare
derrabus
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A nice consequence of this is that we can almost get rid of
doctrine/commonnow. I think we might only depend onClassUtilsnow.