Allow creating mocks of the Query class
#10990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
improvement/unfinal-query
branch
from
af84b4e
to
92f466a
Compare
greg0ire
approved these changes
Oct 10, 2023
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 10, 2023
* 2.17.x: Allow creating mocks of the Query class (doctrine#10990) Add missing "deprecated" annotation on the annotation driver Deprecate EntityManager*::getPartialReference()
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 11, 2023
* 2.17.x: Allow creating mocks of the Query class (doctrine#10990) Add missing "deprecated" annotation on the annotation driver Deprecate EntityManager*::getPartialReference()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #10957.
This change allows mocking the query builder even with the native return types added in 3.0. While we do not recommend or encourage to mock the query builder, I believe we should not actively prevent this kind of test.
This change also allows us to create mocks of the
Queryclass and intercept calls to theQuery::execute()method. The presence of the method shows us that theQueryis not a pure value object, so intercepting this kind of call might be reasonable to a certain degree.