Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up outdated sentence #11224

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Clean up outdated sentence #11224

merged 1 commit into from
Feb 5, 2024

Conversation

BenMorel
Copy link
Contributor

@BenMorel BenMorel commented Feb 5, 2024

Instantiation is done through the static create() method.

The static create() method is gone in version 3.

Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@SenseException SenseException merged commit b00f0c2 into doctrine:3.0.x Feb 5, 2024
64 checks passed
@derrabus
Copy link
Member

derrabus commented Feb 5, 2024

Let's backport to 2.18? The method still exists there, but it's not the recommended way to create an EM anymore.

@derrabus derrabus added this to the 3.0.1 milestone Feb 5, 2024
derrabus added a commit to derrabus/orm that referenced this pull request Feb 7, 2024
* 3.0.x:
  Revert "Merge pull request doctrine#11229 from greg0ire/add-columns"
  Add columns for 3.1.x and 4.0x
  Update version ORM from 2 to 3 in docs (doctrine#11221)
  Clean up outdated sentence (doctrine#11224)
  Update README.md
  Point link to correct upgrade guide (doctrine#11220)
  Ignore subclasses without discriminatorValue when generating discriminator column condition SQL (doctrine#11200)
  Update branches in README
derrabus added a commit to derrabus/orm that referenced this pull request Feb 7, 2024
* 3.1.x:
  Add TokenType class (doctrine#11228)
  Revert "Merge pull request doctrine#11229 from greg0ire/add-columns"
  Add columns for 3.1.x and 4.0x
  Update version ORM from 2 to 3 in docs (doctrine#11221)
  Clean up outdated sentence (doctrine#11224)
  Update README.md
  Point link to correct upgrade guide (doctrine#11220)
  Ignore subclasses without discriminatorValue when generating discriminator column condition SQL (doctrine#11200)
  Update branches in README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants