Address deprecations from Collection 2.2 #11315
Conversation
derrabus
force-pushed
the
bugfix/collections-deprecations
branch
3 times, most recently
from
22d9e83
to
f6ad8d5
Compare
|
"Bug" is not really the right label, is it? |
derrabus
force-pushed
the
bugfix/collections-deprecations
branch
from
f6ad8d5
to
013726b
Compare
derrabus
force-pushed
the
bugfix/collections-deprecations
branch
from
013726b
to
61736af
Compare
The current code triggers deprecations that it should not trigger. That is a bug. But we can reclassify if you're not comfortable shipping this change as a bugfix. |
|
I'm comfortable shipping it in a patch release, but I think we might want to have a separate label for when we address deprecations, like maybe "Addressed deprecation" (can't think of something better right now, sorry). If we say it's a bug, it means other packages can decide to cause bugs in our projects from one release to the next minor release, although we did nothing wrong. |
"Bug" is a totally blame-free word for me. I never said the we could've anticipated the issue that I've fixed here. |
|
I think that makes some sense. Ignore me then. |
* 3.0.x: PHPStan 1.10.59 (doctrine#11320) Address deprecations from Collection 2.2 (doctrine#11315) Fix sql walker phpdoc
* 3.1.x: PHPStan 1.10.59 (doctrine#11320) Address deprecations from Collection 2.2 (doctrine#11315) Deprecate invalid method call Throw a full-fledged exception on invalid call Remove extra word Fix sql walker phpdoc
Part of #11313.