fix: pass join column options to FK #11499
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vencakrecl
force-pushed
the
join-column-option
branch
2 times, most recently
from
2c0eb61
to
fa25d4b
Compare
vencakrecl
force-pushed
the
join-column-option
branch
from
fa25d4b
to
cc2b82f
Compare
|
Thank you. Can you please add a functional test that actually creates such a foreign key? |
vencakrecl
force-pushed
the
join-column-option
branch
from
e882b6d
to
f68b5e3
Compare
|
No, your test compares the generated SQL. But that SQL still does not hit a database. |
|
@derrabus If I understood, should I add the test \Doctrine\Tests\ORM\Functional\SchemaTool\PostgreSqlSchemaToolTest here? |
|
Sounds about right to me. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pass options to FK because of \Doctrine\DBAL\Platforms\PostgreSQLPlatform::getAdvancedForeignKeyOptionsSQL
How to use