Fix OneToManyPersister::deleteEntityCollection missing discriminator column/value. (GH-11500) #11501
Conversation
|
It seems there are CI jobs failing. Please take a look at this guide for more on how to handle those. |
Thanks! Ran the code-beautifier, checked with codesniffer and static analysis tools and pushed amendments. |
| /** | ||
| * @throws EntityNotFoundException | ||
| * @throws MappingException | ||
| */ |
There was a problem hiding this comment.
This replaces DBALException with ORMExceptions. Is this an additional fix because none of them extends the Exception of DBAL?
There was a problem hiding this comment.
DBALException should not have been removed - my IDE autofix appears to have removed that line by mistake. I have pushed an amendment to fix that.
The ORM exceptions are potentially thrown by UnitOfWork::getEntityIdentifier() (EntityNotFoundException) and ClassMetadataInfo::getFieldForColumn() (MappingException).
There was a problem hiding this comment.
I'm not sure if this is a breaking change as this is going to be merged up to 3 and 4 of ORM. But it looks like the DBALException isn't handled either by ORM despite being an Exception of a different library. Now ORMExceptions were added too.
Fixes #11500
This issue may exist in 3.x and 4.x, I haven't yet had a chance to test. If so I can create seperate pull requests for those branches.