Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix join when recreation of query from parts. #1295

Closed
wants to merge 4 commits into from
Closed

Fix join when recreation of query from parts. #1295

wants to merge 4 commits into from

Commits on Feb 9, 2015

  1. Only getting the target platform when it's *actually* needed to avoid… 

    … errors

initialize() is called sometimes, even when the following code doesn't need
the targetPlatform property. Specifically, in AbstractClassMetadataFactory::getAllMetadata().

But as of DBAL 2.5.0, calling Connection::getDatabasePlatform() will make a
connection to the database, which means that sometimes it may fail (e.g. you
haven't configured your database yet). As a result, calling a method like
AbstractClassMetadataFactory::getAllMetadata() - which does not need the
targetPlatform - will fail, because determining the targetPlatform requires
a connection, which fails.

This avoids that - we only get the targetPlatform *when* we need it, which
are cases where we're doing things that do indeed need a connection.
    @weaverryan @NoUseFreak
    weaverryan authored and NoUseFreak committed Feb 9, 2015
    Configuration menu
    Copy the full SHA
    69d0088 View commit details
    Browse the repository at this point in the history

  2. Small code change thanks to the comments and adding a test

    @weaverryan @NoUseFreak
    weaverryan authored and NoUseFreak committed Feb 9, 2015
    Configuration menu
    Copy the full SHA
    57ef628 View commit details
    Browse the repository at this point in the history

  3. Adding docblock

    @weaverryan @NoUseFreak
    weaverryan authored and NoUseFreak committed Feb 9, 2015
    Configuration menu
    Copy the full SHA
    f289ebe View commit details
    Browse the repository at this point in the history

  4. Fix join when recreation of query from parts.

    @NoUseFreak
    NoUseFreak committed Feb 9, 2015
    Configuration menu
    Copy the full SHA
    1e98b4b View commit details
    Browse the repository at this point in the history