Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic overall fixes #1545

Merged
merged 1 commit into from
Nov 7, 2015
Merged

Generic overall fixes #1545

merged 1 commit into from
Nov 7, 2015

Conversation

guilhermeblanco
Copy link
Member

No description provided.

@guilhermeblanco guilhermeblanco self-assigned this Nov 6, 2015
@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-3980

We use Jira to track the state of pull requests and the versions they got
included in.

@@ -412,7 +411,7 @@ class ClassMetadataInfo implements ClassMetadata
*
* @var array
*
* @todo We could get rid of this array by just using $fieldMappings[$fieldName]['columnName'].
* @todo 3.0 Remove this.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a @deprecated

@guilhermeblanco guilhermeblanco force-pushed the general-fixes branch 3 times, most recently from fe2a563 to c6ab0a0 Compare November 7, 2015 02:31
@guilhermeblanco guilhermeblanco changed the title [WIP] General fixes [RFC] General fixes Nov 7, 2015
@guilhermeblanco guilhermeblanco force-pushed the general-fixes branch 4 times, most recently from a418d50 to 69f107e Compare November 7, 2015 03:44
Ocramius added a commit that referenced this pull request Nov 7, 2015
@Ocramius Ocramius merged commit 378f654 into master Nov 7, 2015
@Ocramius Ocramius deleted the general-fixes branch November 7, 2015 03:56
@Ocramius Ocramius changed the title [RFC] General fixes Generic overall fixes Nov 7, 2015
@lcobucci lcobucci added this to the 2.6.0 milestone Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants