Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing method name 'rollBack', which was documented as 'rollback' #1563

Merged

Conversation

rawkode
Copy link
Contributor

@rawkode rawkode commented Nov 21, 2015

No description provided.

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-4009

We use Jira to track the state of pull requests and the versions they got
included in.

@Ma27
Copy link
Contributor

Ma27 commented Nov 30, 2015

https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/UnitOfWork.php#L413
I'm sure that there are enough other occurences of the wrong method name.

@rawkode
Copy link
Contributor Author

rawkode commented Nov 30, 2015

I fixed the other two references - though I'm not sure if you're suggesting that I fix them or just leave them and let PHP's case insensitivity handle it.

@Ma27
Copy link
Contributor

Ma27 commented Nov 30, 2015

I would recommend using something like "Find usages" in phpstorm in order to display all usages of rollBack() in this project, so you can fix them all :)

@rawkode
Copy link
Contributor Author

rawkode commented Nov 30, 2015

Search and replace shows that I've got them all. The only rollback calls left are on the EntityManager class, where the method is actually rollback

@deeky666 deeky666 added this to the 2.6.0 milestone Jan 6, 2016
@deeky666 deeky666 self-assigned this Jan 6, 2016
deeky666 added a commit that referenced this pull request Jan 6, 2016
…d-name

Fixing method name 'rollBack', which was documented as 'rollback'
@deeky666 deeky666 merged commit 1697293 into doctrine:master Jan 6, 2016
@deeky666
Copy link
Member

deeky666 commented Jan 6, 2016

@rawkode thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants