[DDC-551] Add SQLFilter functionality #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was sufficient to use the old parser result for a Query if the DQL didn't change (Query::STATE_CLEAN), but now there must also be no changes to the filter collection of the EntityManager. In the old situation each Query object would create a hash of all the filter objects on it's own. That was not very efficient. This commit adds the state of the current filter collection to the EntityManager. The state will be set to FILTERS_STATE_DIRTY as a filter is enabled, removed or a parameter is set on a filter. The hash is also computed by the EntityManager, but only if the filter collection is dirty. This will prevent recalculation of the hash with each query.
Conflicts: lib/Doctrine/ORM/Persisters/OneToManyPersister.php
Conflicts: lib/Doctrine/ORM/Configuration.php lib/Doctrine/ORM/Persisters/BasicEntityPersister.php lib/Doctrine/ORM/Persisters/ManyToManyPersister.php
Conflicts: lib/Doctrine/ORM/Persisters/BasicEntityPersister.php lib/Doctrine/ORM/Query.php
Still some things to do.
…rsister" This reverts commit f6d5f04.
Conflicts: lib/Doctrine/ORM/Persisters/ManyToManyPersister.php lib/Doctrine/ORM/Persisters/OneToManyPersister.php
| */ | ||
| public function getFilters() | ||
| { | ||
| if(null === $this->filterCollection) { |
There was a problem hiding this comment.
you should add a space after the if
|
Sqlwalker does not apply the correct rules with regard to inheritance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.