code refactorings on persister #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -86,30 +86,30 @@ public function delete(PersistentCollection $coll) | |||
| return; // ignore inverse side | |||
| } | |||
|
|
|||
| $sql = $this->_getDeleteSQL($coll); | |||
| $this->_conn->executeUpdate($sql, $this->_getDeleteSQLParameters($coll)); | |||
| $sql = $this->getDeleteSQL($coll); | |||
|
You rock :) |
|
|
||
| foreach ($updateData as $columnName => $value) { | ||
| $column = $columnName; | ||
|
|
There was a problem hiding this comment.
Remove extra line break
|
Hi guys :) Anything else pending here ? |
| * Check for existance of an element | ||
| * | ||
| * @param \Doctrine\ORM\PersistentCollection $coll | ||
| * @param mixed \Doctrine\ORM\PersistentCollection |
There was a problem hiding this comment.
@ param mixed \Doctrine\ORM\PersistentCollection ?
this seems wrong
|
I'm fine to merge this. Anyone else? |
|
|
||
| /** | ||
| * @var \Doctrine\ORM\UnitOfWork | ||
| */ | ||
| protected $_uow; | ||
| protected $uow; |
There was a problem hiding this comment.
This would be a BC break for people extending the persisters as they are protected properties
There was a problem hiding this comment.
and the same is true for protected methods
There was a problem hiding this comment.
Persisters are currently unable to be extended anyway. It cannot be classified as a BC break. =)
|
Done, Thanks @guilhermeblanco and @stof |
|
I'm fine with the code. Please rebase. |
|
Hi @guilhermeblanco, the performance tests are almost the same .. doctrine/master :My branch : |
beberlei
added a commit
that referenced
this pull request
Nov 25, 2012
code refactorings on persister
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi
This patch does not add any feature, just small refactorings and code clean up.
It make easier to implement the generation of persisters:
http://www.doctrine-project.org/jira/browse/DDC-1889
Cheers ...