Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Fixes missing namespaces on class call #6207

Merged
merged 1 commit into from
Jan 2, 2017
Merged

Documentation: Fixes missing namespaces on class call #6207

merged 1 commit into from
Jan 2, 2017

Conversation

gabidavila
Copy link
Contributor

On http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/tools.html#reverse-engineering there are calls like the following:

$cmf = new DisconnectedClassMetadataFactory();

Which would cause fatal error if not in the namespace call list, however as documentation for this feature already starts with

$em->getConfiguration()->setMetadataDriverImpl(
    new \Doctrine\ORM\Mapping\Driver\DatabaseDriver(
        $em->getConnection()->getSchemaManager()
    )
);

I added the namespace on the calls itself to maintain consistency.

@Ocramius Ocramius self-assigned this Jan 2, 2017
@Ocramius Ocramius self-requested a review January 2, 2017 18:40
@Ocramius Ocramius added this to the 2.6.0 milestone Jan 2, 2017
@Ocramius
Copy link
Member

Ocramius commented Jan 2, 2017

@gabidavila thanks! 👍

@Ocramius Ocramius merged commit 06691e0 into doctrine:master Jan 2, 2017
@gabidavila
Copy link
Contributor Author

;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants