Fix HHVM build according to Travis documentation #6286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcobucci
force-pushed
the
fix-hhvm-version
branch
from
80f4fa8
to
2da26a8
Compare
|
@Ocramius now the test suite at least runs but something is failing miserably when trying to create a connection using ubuntu trusty 😞 |
We were expecting a return value for all methods but on doctrine/common@6a56df9 we changed some methods to be void and of course that affected the ORM.
lcobucci
force-pushed
the
fix-hhvm-version
branch
from
2da26a8
to
02e8ae5
Compare
lcobucci
force-pushed
the
fix-hhvm-version
branch
from
02e8ae5
to
d03ff47
Compare
|
Alright, I give up too 😞 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://docs.travis-ci.com/user/languages/php#HHVM-versions-on-Trusty