Skip not mapped public properties in SchemaValidator #737
Conversation
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-2577 We use Jira to track the state of pull requests and the versions they got |
| @@ -241,6 +241,10 @@ public function validateClass(ClassMetadataInfo $class) | |||
| continue; | |||
| } | |||
|
|
|||
| if (!isset($class->fieldMappings[$publicAttr->getName()]) && !isset($class->associationMappings[$publicAttr->getName()])) { | |||
There was a problem hiding this comment.
We use a CS that demands a space between !. We also restrict the column length to 120 chars.
There was a problem hiding this comment.
I know that, but please take a look at this file https://github.com/Koc/doctrine2/blob/ebbfe504ee69a9e551a3e74bac740ef73b060e55/lib/Doctrine/ORM/Tools/SchemaValidator.php#L93, L99, L120, ... . Imho added lines should be consistent with other lines in same file.
There was a problem hiding this comment.
@Koc that's just because we refuse CS cleanup pull requests. New code coming in should respect the CS and follow strict calisthenics wherever possible. Ignore the rest please.
|
@guilhermeblanco done |
Skip not mapped public properties in SchemaValidator
No description provided.