Use dedicated assertContainsOnlyInstancesOf PHPUnit assertion #7440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
suggested changes
Oct 22, 2018
There was a problem hiding this comment.
@carusogabriel please make sure the minimum PHPUnit version in composer.json has these assertions built in (may already be the case)
|
@Ocramius The minimum version required by Edit: this assertion is present since PHPUnit 4.8. |
Ocramius
approved these changes
Oct 22, 2018
|
@Ocramius Can we merge this one? |
|
🚢 (had to disable checks to merge, since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.