Merge up 2.6 to 2.7 #7900
Merged
Merge up 2.6 to 2.7 #7900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `WhereInWalker` does not run, query parameters are not translated from their in-memory type to the expected SQL type when the paginator is run again with the same DQL string. This is an architectural issue, since (for the sake of simplicity) we moved parameter translation into the SQL walker, we didn't consider that SQL walkers only act when no cache is in place. The translatio needs to be moved into the paginator logic again.
In order to figure out the paginated query identifier type, we would have to parse the DQL query into an AST+SQL anyway, so we'd have to re-parse it manually: instead of doing that, we can force the `WhereInWalker` to be reached at all times by forcing the `$whereInQuery` to use no query cache. While it is a sad performance regression, it is also not a noticeable one, since we'll be performing an `O(1)` operation around an I/O one (query execution, in this case).
Update documentation to recommend DQL over QueryBuilder when possible
[Documentation] Advanced field value... - missing entity alias
Use quoted collation declaration when available.
greg0ire
previously approved these changes
Nov 14, 2019
Otherwise, getClassMetadata would be triggered more times
…nWithCachedQueryParsing
UnitOfWork::clear() misses $eagerLoadingEntities
…-identifier-types-even-with-cached-dql-parsing #7837 paginate with custom identifier types even with enabled DQL query cache
|
Let's hold this for now until |
only replace '_id' at end of columnName
Delete statements will not be created using `clear`
lcobucci
force-pushed
the
2.6.x-merge-up-into-2.7
branch
from
387e620
to
81167fd
Compare
lcobucci
previously approved these changes
Nov 15, 2019
There was a problem hiding this comment.
Actually, let's get it merged in since it fixes the build state. We can do another merge up afterwards. I've added the new commits in 2.6.
Thanks @ostrolucky
|
I think |
|
Also, the composer.lock is out of sync, I'm going to try to fix both issues. |
|
Oh I see you just fixed that issue in 2.7 @lcobucci , I'm going to redo the merge then |
|
I've addressed this in 2.7 already 👍 |
greg0ire
force-pushed
the
2.6.x-merge-up-into-2.7
branch
from
b36b1c2
to
fc9314d
Compare
greg0ire
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.