Convert PHP to SQL for new object expression #8062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fields used in the new object expression. Were not yet converted to via their configured type/convertToPHPValueSQL. This can lead to incorrect arguments being injected into the new object. This is fixed by calling convertToPHPValueSQL while creating the SQL query.
|
Thank you for your addition to the NEW object syntax. The implementation looks good, but I'm not sure if this belongs into the 2.7 branch. This looks more like an improvement than a bugfix. @doctrine/team-orm |
|
Hard to say. I'm ok with both. |
|
It might be both. I considered it a bug because for me this is unexpected behavior. The custom types mapping documentation also doesn't mention anything specific about not supporting the new object syntax. |
|
@SenseException or @ostrolucky what should I do to get this changed merged? |
ostrolucky
approved these changes
Apr 14, 2020
SenseException
approved these changes
Apr 16, 2020
|
Thanks @ostrolucky and @SenseException ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fields used in the new object expression. Were not yet converted to via
their configured type/convertToPHPValueSQL. This can lead to incorrect
arguments being injected into the new object.
This is fixed by calling convertToPHPValueSQL while creating the SQL
query.
This fixes issue #8061