Add psalm template support to several types #8289
Conversation
|
Note that a previous commit in 2.7 made some changes to attribute names: This will have to be fixed while merging as Psalm's annotation will have the old param name. I'll gladly fix it myself if needed after the merge is performed. |
|
I'm not sure what's up with CI... |
orklah
force-pushed
the
templates-psalm
branch
from
6ed17b7
to
b86bff6
Compare
|
Travis is slow tonight it seems. |
I think I fixed it in the past (#8252) but the merge-base of 2.7 and 2.8.x dates from August 😅 |
If this is a fix, why are you targeting 2.8.x? |
|
#8311 should fix the build issue |
|
Ah sorry, I was confused by the wording. In that sort of case, I'd use "This should close #8283", because it is a feature request. Anyway, I fixed the build, let's restart it here. |
|
Thanks @orklah ! |
|
Thanks :) |
Doctrine has added the required Psalm annotations since 2.8: doctrine/orm#8289
Doctrine has added the required Psalm annotations since 2.8: doctrine/orm#8289
* [minor] re-enable psalm * Removed WeirdanDoctrinePsalmPlugin Doctrine has added the required Psalm annotations since 2.8: doctrine/orm#8289 * Added function-scope template for proxyResult() Nothing actually guarantees that a TProxiedObject is provided. This local template var somehow fixed Psalm's understanding of this method. * Fixed CS Co-authored-by: Kevin Bond <kevinbond@gmail.com>
Hi,
This should fix #8283
I was suprised not to find all the method subbed in https://github.com/weirdan/doctrine-psalm-plugin/blob/master/stubs/EntityManagerInterface.phpstub in the EntityManagerInterface. Turns out they're defined in the parent class which is part of Doctrine\Persistence (The version installed via composer seem to already have the psalm's annotation though)
CS will probably fail. I'll fix it soon