Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed memory leak while iterating results #8412

Closed
wants to merge 1 commit into from
Closed

Conversation

stlrnz
Copy link

@stlrnz stlrnz commented Jan 6, 2021

I've tried to fix the issue described in #8410

@beberlei
Copy link
Member

beberlei commented Jan 6, 2021

@simPod can you say something?

@stlrnz
Copy link
Author

stlrnz commented Jan 6, 2021

I've checked why the test https://github.com/doctrine/orm/pull/8412/checks?check_run_id=1654953910 failed.

It seems that the ObjectHydrator in contrast to the SimpleObjectHydrator does need $result to be persistent.
So maybe this is not the correct solution for the linked issue?

@simPod
Copy link
Contributor

simPod commented Jan 6, 2021

@stirnz same test run fails for iterate() as well, it was not tested for that case though while toIterable() is. Looking into it.

@simPod
Copy link
Contributor

simPod commented Jan 6, 2021

I remember being tasked with fixing #3238 which introduced the memory leak as we're keeping result in memory now. Looking for workaround.

@beberlei
Copy link
Member

beberlei commented Feb 5, 2021

Related #8414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants