refac: remove duplicate code from AbstractQuery #8831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`AbstractQuery::getSingleResult` is 90% the same code as `AbstractQuery::getOneOrNullResult` the only different is that `AbstractQuery::getOneOrNullResult` catch the `NoResultException` and return null.
| } catch (NoResultException $e) { | ||
| return null; | ||
| } | ||
|
|
||
| if ($this->_hydrationMode !== self::HYDRATE_SINGLE_SCALAR && ! $result) { | ||
| return null; |
There was a problem hiding this comment.
getSingleResult throws an exception here instead of returning null.
There was a problem hiding this comment.
@SenseException yes the new code catch the NoResultException and return null same as before.
SenseException
approved these changes
Jul 15, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractQuery::getSingleResultis 90% the same code asAbstractQuery::getOneOrNullResultthe only different is thatAbstractQuery::getOneOrNullResultcatch theNoResultExceptionand return null.