Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Attributes code block #9161

Merged
merged 1 commit into from
Nov 20, 2021
Merged

Conversation

ThomasLandauer
Copy link
Contributor

Just that there is some real-world example somewhere ;-) see #9020 (comment)

Just that there is some real-world example somewhere ;-) see doctrine#9020 (comment)
{
// ....
}
.. code-block:: annotation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This defines the code coloration and therefore will not work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know what you mean :-( What I'm trying to create is basically the same as in doctrine/doctrine-website#409

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mb it looks supported!

@derrabus derrabus merged commit db14f0f into doctrine:2.10.x Nov 20, 2021
@ThomasLandauer ThomasLandauer deleted the patch-9 branch November 20, 2021 18:16
derrabus added a commit that referenced this pull request Nov 28, 2021
* Adding Attributes code block (#9161)

Just that there is some real-world example somewhere ;-) see #9020 (comment)

* Use `equal to` instead of `equal of` in `assertSqlGeneration()` (#9195)

* Add a psalm type for field mapping

Field mapping have different definitions
in property definition and method return.
As suggested in issue and to avoid further desynchronization,
a psalm type has been created.
Fixes #9193

* Psalm 4.13.1, PHPStan 1.2.0 (#9204)

Co-authored-by: Thomas Landauer <thomas@landauer.at>
Co-authored-by: Simon Podlipsky <simon@podlipsky.net>
Co-authored-by: Julien LARY <47776596+laryjulien@users.noreply.github.com>
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
derrabus added a commit to derrabus/orm that referenced this pull request Nov 29, 2021
* 2.11.x:
  Add missing deprecations for YAML metadata mapping (doctrine#9206)
  Drop support for DBAL 3.1
  Psalm 4.13.1, PHPStan 1.2.0 (doctrine#9204)
  Add a psalm type for field mapping
  Use `equal to` instead of `equal of` in `assertSqlGeneration()` (doctrine#9195)
  Adding Attributes code block (doctrine#9161)
derrabus added a commit to derrabus/orm that referenced this pull request Nov 29, 2021
* 2.11.x:
  Add missing deprecations for YAML metadata mapping (doctrine#9206)
  Drop support for DBAL 3.1
  Psalm 4.13.1, PHPStan 1.2.0 (doctrine#9204)
  Add a psalm type for field mapping
  Use `equal to` instead of `equal of` in `assertSqlGeneration()` (doctrine#9195)
  Adding Attributes code block (doctrine#9161)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants