Feature/console em helper interface #926
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…structor argument, instead of insisting on an EntityManager
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-2946 We use Jira to track the state of pull requests and the versions they got |
|
This is a problem not only of EM helper. I'm afraid it won't be accepted due backward incompatibility. See also #924. |
|
@Majk578 - I don't see how it breaks BC. As far as I can tell, using the decorator/interface is the way we're supposed to go. It just appears like there are still places that say EntityManager that should say EntityManagerInterface because people haven't gotten around to fixing them. This PR is one such fix. |
|
Replacing this with #927 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\Doctrine\ORM\Tools\Console\Helper\EntityManagerHelper demands a concrete EntityManager. This PR allows it to accept anything that implements EntityManagerInterface.