Make test types compatible with Doctrine DBAL 4.0.x-dev #9402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
commented
Jan 18, 2022
| @@ -66,36 +66,30 @@ public function testFetchObjectWithAutoIncrementedCustomType(): void | |||
| } | |||
| } | |||
|
|
|||
| class DDC5684ObjectIdType extends DBALTypes\IntegerType | |||
| class DDC5684ObjectIdType extends DBALTypes\BigIntType | |||
There was a problem hiding this comment.
This is a hack to be able to return a non-integer value from convertToPHPValue() and have the column autoincremented at the same time. Not sure how valid this test is in the first place.
derrabus
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step towards making the ORM test suite compatible with DBAL 4.0.x-dev.
The test type classes may be reworked by adding return type declarations and remain compatible with DBAL 3.x. Other mock classes (e.g.
DatabasePlatformMock) will have to be replaced with PHPUnit mocks since it's impossible to implement both the DBAL 3.x and 4.0-x SPIs statically (without code generation).