Streamline cache creation in tests #9451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Jan 31, 2022
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Jan 31, 2022
* 2.12.x: Support enums in findBy() calls (doctrine#9453) Streamline cache creation in tests (doctrine#9451)
n-e-m-a-nj-a
pushed a commit
to n-e-m-a-nj-a/orm
that referenced
this pull request
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our functional tests, we evaluate a global variable
DOCTRINE_CACHE_IMPLwhich allows us to change the Doctrine Cache implementation of the metadata cache. I am not aware that we use that feature anywhere in the CI. Also, when migrating away from Doctrine Cache, we would need to revamp that "feature".This is why I'd like to remove that feature entirely.
Additionally, since we lazily create multiple caches in our test suite, I wanted to make sure we always do it the same way.