Fix types on QueryBuilder #9492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
commented
Feb 8, 2022
Comment on lines
+52
to
+56
| ->setParameters(new ArrayCollection([ | ||
| new Parameter('e', $employee1), | ||
| new Parameter('date', $date1), | ||
| new Parameter('salary', 101), | ||
| ])) |
There was a problem hiding this comment.
This test used the deprecated API of setParameters() which I'd like to remove on 3.0.
derrabus
force-pushed
the
types/query-builder-backports
branch
from
a912a78
to
f983b08
Compare
SenseException
approved these changes
Feb 8, 2022
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Feb 9, 2022
* 2.12.x: Fix types on QueryBuilder (doctrine#9492) Fix types on EntityRepository (doctrine#9474) Avoid calling merge() (doctrine#9489) PHPStan 1.4.6, Psalm 4.20.0 (doctrine#9491) Fix `#[DiscriminatorMap]` params (doctrine#9487) Run tests with stricter error handling (doctrine#9482)
n-e-m-a-nj-a
pushed a commit
to n-e-m-a-nj-a/orm
that referenced
this pull request
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backpots from #9490