Replace TreeWalkerChainIterator with a generator
#9511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
deprecate/tree-walker-iterator
branch
from
09688ee
to
34ba81a
Compare
derrabus
changed the title
TreeWalkerChainIterator with a generator
greg0ire
reviewed
Feb 15, 2022
| <code>walkUpdateItem</code> | ||
| <code>walkUpdateStatement</code> | ||
| <code>walkWhereClause</code> | ||
| </PossiblyNullReference> |
greg0ire
approved these changes
Feb 15, 2022
This was referenced Feb 15, 2022
n-e-m-a-nj-a
pushed a commit
to n-e-m-a-nj-a/orm
that referenced
this pull request
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating the type errors on the tree walker classes, I stumbled on
TreeWalkerChainIterator. This class seems unnecessarily complex and can easily replaced with a three-line generator function. So I did just that.