Leverage Lexer's Token type #9549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
improvement/leverage-token-type
branch
from
9d1f10b
to
548a955
Compare
greg0ire
reviewed
Feb 28, 2022
derrabus
force-pushed
the
improvement/leverage-token-type
branch
from
548a955
to
f82db6a
Compare
|
I've followed your suggestion and bumped Lexer. I guess it's better for our sanity if we keep the version range small here. After all, ORM and Lexer are very tightly coupled. |
greg0ire
approved these changes
Feb 28, 2022
|
Not sure why Codecov hangs, but let's merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows doctrine/lexer#64
The Lexer now exposes a Psalm type for the token array. Since that array structure is used by the parser internally, it makes sense to reuse it to make Psalm a little smarter.