Document tree walker class strings #9553
Conversation
| * @param Query $query The parsed Query. | ||
| * @param ParserResult $parserResult The result of the parsing process. | ||
| * @psalm-param array<string, QueryComponent> $queryComponents The query components (symbol table). |
There was a problem hiding this comment.
Psalm seems to ignore @inheritDoc on constructors. 🤷🏻♂️
There was a problem hiding this comment.
It is supposed to work though: vimeo/psalm#4504 (comment)
There was a problem hiding this comment.
But I think you'd need to add psalm-consistent-constructor on the interface as well (or in fact, only there? not sure if it's necessary to have it in this class). Can you please try that?
There was a problem hiding this comment.
Doesn't really work. If I add this annotation to the interface, @inheritdoc on SqlWalker's constructor is still ignored. If I remove the attotation from SqlWalker, @inheritdoc works again, but this also brings back the UnsafeInstantiation error for new $outputWalkerClass. 😕
There was a problem hiding this comment.
Ok, I guess defining a constructor in an interface is quite the corner case.
| @@ -220,7 +220,7 @@ class Parser | |||
| /** | |||
| * The custom last tree walker, if any, that is responsible for producing the output. | |||
| * | |||
| * @var class-string<TreeWalker> | |||
| * @var class-string<SqlWalker>|null | |||
There was a problem hiding this comment.
As explained on #9551, output walkers cannot be arbitrary implementations of TreeWalker, we do expect an SqlWalker here.
Another backport from #9551