Fix types on ResultSetMapping #9621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
commented
Mar 31, 2022
| * @param string $alias The result alias with which the scalar result should be placed in the result structure. | ||
| * @param string $type The column type | ||
| * @param string $columnName The name of the column in the SQL result set. | ||
| * @param string|int $alias The result alias with which the scalar result should be placed in the result structure. |
There was a problem hiding this comment.
I'm widening the type here because we pass an integer in this line:
orm/lib/Doctrine/ORM/Query/SqlWalker.php
Line 1637 in 18d6bc3
The $resultAlias is definitely an int as we can see here:
orm/lib/Doctrine/ORM/Query/SqlWalker.php
Line 1587 in 18d6bc3
An alternative approach would be to cast the integer to a string.
derrabus
force-pushed
the
types/rsm-backports
branch
from
ce5d5d0
to
305bb49
Compare
derrabus
force-pushed
the
types/rsm-backports
branch
from
305bb49
to
64a2451
Compare
greg0ire
approved these changes
Apr 4, 2022
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Apr 4, 2022
* 2.12.x: Fix types on ResultSetMapping (doctrine#9621)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares #9620 on the 2.12.x branch.