Migrate tests to PHP8 syntax #9800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 1, 2022
Closed
Merged
greg0ire
force-pushed
the
rector-tests
branch
4 times, most recently
from
24ef06a
to
7a62ca6
Compare
This causes the following error for some reason: Typed property Doctrine\Tests\ORM\Functional\TrainOrder::$train must not be accessed before initialization
This causes "Cannot assign string to property Doctrine\Tests\Models\Cache\ComplexAction::$action2 of type Doctrine\Tests\Models\Cache\Action" for some reason.
The order is not the same as in the constructor, and that seems to matter.
derrabus
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.