Allow custom object types as foreign keys #9927
Conversation
Hello, I would like to make a small change. The need arose when using \Symfony\Bridge\Doctrine\IdGenerator\UuidGenerator in "symfony/doctrine-bridge" composite foreign keys I'm sure these changes will not hurt performance and allow other objects to be used as identifiers
Fix for coding-standards / Coding Standards (8.1)
|
Your test is failing, can you have a look? |
|
I'm on it! 😊 |
louisezetterlund
force-pushed
the
patch-1
branch
from
958a8f3
to
e5650de
Compare
louisezetterlund
force-pushed
the
patch-1
branch
from
e5650de
to
705dc6f
Compare
There was a problem hiding this comment.
The PR looks good.
One more thing, @louisezetterlund: Your commit is signed with some kind of local e-mail-address. You can see that when you run git log on your branch.
I don't know if that was your intention or if your git client is just not set up properly. I can merge this PR as is, but then your GitHub account won't be listed as a contributor to this repository.
You can find out more about setting up you commit email address here. Here you can also learn what email address to use if you want to keep your real email address private.
|
All right, @greg0ire has already merged it. 🤷🏻 Anyway, thanks for your PR. And please have a look at the article I've linked, so future contributions can be attributed to you properly. |
derrabus
changed the title
Continues #9793 which updates IdentifierFlattener to work with foreign keys with custom id object types. This PR adds a test for #9793.
Fixes #9335