Add type to ColocatedMappingDriver::isTransient()#318
Merged
derrabus merged 1 commit intodoctrine:3.1.xfrom Dec 13, 2022
Merged
Add type to ColocatedMappingDriver::isTransient()#318derrabus merged 1 commit intodoctrine:3.1.xfrom
ColocatedMappingDriver::isTransient()#318derrabus merged 1 commit intodoctrine:3.1.xfrom
Conversation
greg0ire
reviewed
Dec 13, 2022
Member
greg0ire
left a comment
greg0ire
left a comment
There was a problem hiding this comment.
There are build issues to address.
derrabus
force-pushed
the
types/mapping-driver
branch
from
30106bb to
f5c65af
Compare
Member
Author
|
Done. |
greg0ire
approved these changes
Dec 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
MappingDriver::isTransient()was upgraded with a type for the$classNameparameter, but apparently we forgot to do the same on theColocatedMappingDrivertrait. This PR corrects this mistake. Adding the type to an abstract method should be safe in PHP 7.2 and up.