Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the ACMF::doLoadMetadata docblock #327

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Conversation

mpdude
Copy link
Contributor

@mpdude mpdude commented Jan 18, 2023

No description provided.

@derrabus
Copy link
Member

PHPCS fails. 🙂

@mpdude
Copy link
Contributor Author

mpdude commented Jan 18, 2023

Why can’t it just automatically commit the necessary fixes?

@derrabus
Copy link
Member

🤷🏻‍♂️

@greg0ire
Copy link
Member

Hey why don't you use a pre-push hook instead of blaming our beautiful pipeline? It will be useful for other commands that can't be autofixed, and will be better for the planet in cases where phpcs is not the only failing job:

#!/bin/bash
set -e
echo ''|vendor/bin/phpcs
vendor/bin/phpstan
vendor/bin/psalm
vendor/bin/phpunit

@greg0ire greg0ire merged commit 920da29 into doctrine:3.1.x Jan 19, 2023
@greg0ire greg0ire added this to the 3.1.3 milestone Jan 19, 2023
@mpdude mpdude deleted the patch-2 branch January 19, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants