Add missing proxy methods #348
Conversation
greg0ire
force-pushed
the
missing-methods
branch
from
fc59bb6
to
79ba7c6
Compare
| @@ -10,6 +10,16 @@ parameters: | |||
| count: 1 | |||
| path: src/Persistence/Reflection/EnumReflectionProperty.php | |||
|
|
|||
| - | |||
| message: "#^Method Doctrine\\\\Persistence\\\\Reflection\\\\EnumReflectionProperty\\:\\:getDeclaringClass\\(\\) return type with generic class ReflectionClass does not specify its types\\: T$#" | |||
There was a problem hiding this comment.
This should be solved by making EnumReflectionProperty generic on the class name, as done in the stubs for ReflectionProperty in Psalm and phpstan instead of adding it in the baseline IMO.
There was a problem hiding this comment.
I agree, but I'm not sure how I can make the type flow from the constructor to there 🤔 I think I'm supposed to leverage ReflectionProperty's template types, if there are some, but I don't know where to find their definitions.
There was a problem hiding this comment.
hmm, apparently, Psalm makes ReflectionProperty generic but phpstan does not. So I'm not sure solving this one is actually possible.
greg0ire
force-pushed
the
missing-methods
branch
from
79ba7c6
to
f9f9dcf
Compare
| } | ||
|
|
||
| /** {@inheritDoc} */ | ||
| public function getName(): string |
There was a problem hiding this comment.
you should be adding the @psalm-immutable annotation (which is not the same than @psalm-pure that you tried)
There was a problem hiding this comment.
I tried it locally, to no avail, then noticed I still had Psalm 4, apparently because Psalm 5 is not compatible with php 8.3 yet, so I just tried pushing, and it doesn't work with Psalm 5 either.
There was a problem hiding this comment.
There was a problem hiding this comment.
Just @psalm-external-mutation-free seems sufficient.
greg0ire
force-pushed
the
missing-methods
branch
3 times, most recently
from
139c0e0
to
6f0e8b8
Compare
I somehow thought I had a green build for the ORM after e70bc39, but I really didn't.
greg0ire
force-pushed
the
missing-methods
branch
from
6f0e8b8
to
5bed91c
Compare
I somehow thought I had a green build for the ORM after #343, but I really didn't.
Picked the patch release since it's something I forgot and the release is fresh, but please do tell if you think I should be strict about this and target 3.4.x instead.