-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force uppercase SQL keywords #93
Conversation
How does this PR relate to #73? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From #73:
This adds a new optional third parameter to the format method, $forceUppercase which defaults to false to maintain backwards compatibility.
I don't think we should consider changing case as breaking compatibility.
I don't see the benefit of keeping compatibility in this case. |
I'm not saying we should not keep compatibility, I'm saying that we should consider that we are keeping it: a change in case should IMO be considered compatible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a change in case should IMO be considered compatible.
I haven't worked with a SQL dialect yet that was case sensitive.
Thanks @rinu ! |
I don't see any benefit to anyone ever having lowercase keywords.
Not all reserved words are detected correctly in this project. A simple regex is simple but it lacks context. But so what, if it's a field name, put ticks around it.
Closes #73