Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username min length description does not match schema #981

Closed
6 tasks done
McPizza0 opened this issue Mar 1, 2024 · 1 comment · Fixed by #982
Closed
6 tasks done

Username min length description does not match schema #981

McPizza0 opened this issue Mar 1, 2024 · 1 comment · Fixed by #982
Assignees
Labels
status: assigned Issue has been assigned type: bug Something isn't working

Comments

@McPizza0
Copy link
Contributor

McPizza0 commented Mar 1, 2024

Issue Description

when registering a username, if you enter exactly 6 characters you will get back an error
Only subscribers can have a username shorter than 6 characters

technically 6 characters is not shorter than 6 characters, and based on the error message its safe to assume 6 characters should be accepted

when validating the username we check if username.length <= 6 meaning only 7 or more characters will be true

the check is here:

if ((true || IS_BILLING_ENABLED()) && url && url.length <= 6) {

Steps to Reproduce

signup, enter a 6 character string as username

Expected Behavior

for 6 character strings to be accepted

Current Behavior

6 character strings are rejected

Screenshots (optional)

No response

Operating System [e.g., Windows 10]

No response

Browser [e.g., Chrome, Firefox]

No response

Version [e.g., 2.0.1]

No response

Please check the boxes that apply to this issue report.

  • I have searched the existing issues to make sure this is not a duplicate.
  • I have provided steps to reproduce the issue.
  • I have included relevant environment information.
  • I have included any relevant screenshots.
  • I understand that this is a voluntary contribution and that there is no guarantee of resolution.
  • I want to work on creating a PR for this issue if approved
@McPizza0 McPizza0 added the type: bug Something isn't working label Mar 1, 2024
@github-actions github-actions bot added the status: triage Scope to be determined label Mar 1, 2024
Copy link

github-actions bot commented Mar 1, 2024

Thank you for opening your first issue and for being a part of the open signing revolution!

One of our team members will review it and get back to you as soon as it possible 💚

Meanwhile, please feel free to hop into our community in Discord

@Mythie Mythie added status: assigned Issue has been assigned and removed status: triage Scope to be determined labels Mar 1, 2024
Mythie added a commit that referenced this issue Mar 2, 2024
fixed #981 

`url.length <= 6` >>> `url.length < 6`

also removed debug message from the form component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: assigned Issue has been assigned type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants